On Fri, 2011-07-08 at 15:36 -0700, Shawn Walker wrote:
> > pkgsend generate SUNWfoo/ produces different (incorrect) output to
> > pkgsend generate SUNWfoo
>
> I don't recall you mentioning that, but now that I see it, I'll go fix it.
Thanks.
> > I notice that license actions are still being given 'path' attributes,
> > which conflicts with an existing pkglint check.
>
> I've had to continue to let the bundle code add the attribute as the
> importer relies on 'path' being there.
>
> However, I've changed pkgsend to pop the attribute off during pkgsend
> generate.
Great!
> > src/pkg/pkglint_whitelist.txt
> >
> > These changes aren't right. You're correct that this was the way we
> > used to make pkglint shutup, but isn't the way to fix the problem now.
>
> So what purpose does pkglint_whitelist.txt serve? The error message you
> get when there's a difference seems to indicate this is correct solution.
Yes, we should fix that error message. Essentially pkglint_whitelist is
the equivalent of the ON nightly lint-noise check: it's not part of
pkglint(1) itself, rather a bolt-on that we use in the gate to see
whether our build has started to emit new lint warnings or errors.
Adding dependencies to external_deps.pkglintrc is a special case, as we
decided that having a pkglint built-in to ignore just those particular
lint-errors would be a feature worth including in the tool itself (since
the warning about missing dependencies is commonplace, but necessary)
> > The errors about the new variants are more problematic, and really need
> > to be worked around by adding "pkg.linted.pkglint.manifest003.1=true"
> > set actions to the manifests that are reporting the errors. The
> > underlying problem you're running into is bug 18673, at which point we
> > can remove the pkg.linted flags.
>
> Bleargh.
..
> Double bleargh.
I agree entirely. I'd like to have a go at cleaning up our use of
pkglint a little bit, but it's not a priority at the moment.
> I've changed as above.
Excellent, much appreciated,
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
