On 07/07/11 23:50, Alan Coopersmith wrote:
On 07/ 7/11 09:10 PM, Shawn Walker wrote:
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-publish-1/webrev/
Only reviewing the man page -
- Under generate only two SVR4 package parameters are listed as being
converted, I'd have expected more, such as:
SVR4 pkginfo(4) pkg(5) action/attribute
--------------- -----------------------
ARCH (if not "all") variant.arch
PKG pkg.fmri name string
VERSION pkg.fmri version string
(common subset) legacy action
Nope; those all get converted to legacy actions. You'd have to ask Tim
for the reasons why.
Does BASEDIR get added to paths?
BASEDIR is removed from relocatable paths; I've added a comment.
- What does --target do in publish? Doesn't it not apply since the manifest
specifies which file is target vs. link?
It applies because it affects how the bundle code interprets sources as
it parses them. However, this option shouldn't be necessary as I
already have the manifest to tell much which sources I want to treat as
files instead of hardlinks.
- Example 1 fails when using csh or tcsh, since their echo builtins don't handle
"\n", specifying /usr/bin/echo fixes it for them.
I've reworded this to simply ask the user to create a file containing
the two lines.
- An example of using pkgsend generate might be nice. Especially if it showed
the requirement to add a "set pkg.fmri" manually when generating a manifest
from a non-SVR4 source, since you've removed the option to specify that on
the command line.
Yes, I've added one.
- eval(1) should be removed from See Also, since it was part of the old
transaction examples. I'm not sure why ftpusers(4), group(4),
passwd(4), shadow(4) were mentioned there - they would make sense for
discussion of user actions, but I don't see any mention of those.
Yeah, those are gone now.
- Should a mention/see also of pkglint be added for checking the generated
manifest, much as you have for pkgdepend?
Oi. Sure.
- Even though it's now documented as pkgsend publish -s /path/to/repo, please
continue to accept pkgsend -s /path/to/repo publish for a few builds if
possible so we don't have to have a cross-consolidation flag day.
Uh, don't you know me better by now :) ?
Yes, of course -s works both as a global option and as an option to the
'publish' subcommand.
This is the same as pkgrepo and was done on purpose for the sake of the
user.
Yes, not all options can come before or after the command, but I thought
-s should be able to at the very least.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
