On Thu, Jul 07, 2011 at 02:18:12PM -0700, Danek Duvall wrote:
> Here:
>
> https://cr.opensolaris.org/action/browse/pkg/dduvall/hashattr/webrev/
>
> is a webrev for:
>
> 18630 cannot publish an action where the payload hash contains an equals
> 18648 underscore removal, part 1: informational attributes
>
> which should be fairly straightforward.
src/tests/api/t_action.py
- you test that a hash= attribute in a string action gets translated
into a positional hash value after converting into and object and back
into a string, shouldn't you also test that a hash= attribute with an
= in the value doesn't get translated into a positional value?
- you say:
The payload hash can't be specified as both a named and a positional
attribute.
but in pkg.5.txt you say:
Both may be used in the same action; however, the hashes must be identical.
and in _actions.c it seems that pkg.5.txt is correct. if perhaps you
could update the comment in the test? also, perhaps we should have a
test that checks that identical hash values work?
otherwise lgtm.
ed
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
