On 07/08/11 16:31, Danek Duvall wrote:
Edward Pilatowicz wrote:
src/tests/api/t_action.py
- you test that a hash= attribute in a string action gets translated
into a positional hash value after converting into and object and back
into a string, shouldn't you also test that a hash= attribute with an
= in the value doesn't get translated into a positional value?
Good catch. I've uploaded
https://cr.opensolaris.org/action/browse/pkg/dduvall/hashattr-2/webrev/
which properly stringifies actions with equals signs in their payload
hashes, and adds a few more tests. Only generic.py and t_action.py are
changed.
Does the __str__ change have any meaningful impact on the perfbench tests?
I'd also mention that you've updated pkgsend.1.txt, but I've removed
that entire section in this webrev:
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-publish-1/webrev/src/man/pkgsend.1.txt.wdiff.html
I did so with the belief that since I was removing the action-by-action
publication commands, pkgsend(1) should only document usage of the
utility, while pkg(5) should document the actions.
Please review the changes there and tell me what you think should happen.
Otherwise, your changes seem right to me.
Thanks,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
