On 07/11/11 11:50, Danek Duvall wrote:
Shawn Walker wrote:

     https://cr.opensolaris.org/action/browse/pkg/dduvall/hashattr-2/webrev/

Does the __str__ change have any meaningful impact on the perfbench tests?

Not really.  There's a lot of noise in the data, but over six runs, there's
about a 2% drop on creation, and about a 3-5% drop on stringification.

Cool; just checking.

I'd also mention that you've updated pkgsend.1.txt, but I've removed
that entire section in this webrev:

https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-publish-1/webrev/src/man/pkgsend.1.txt.wdiff.html

I did so with the belief that since I was removing the action-by-action
publication commands, pkgsend(1) should only document usage of the
utility, while pkg(5) should document the actions.

That seems reasonable to me.  I'll adapt my changes if you go in first.

Okay, I'll go ahead and putback then. I was just waiting for your comments on this.

Thanks,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to