On 02/01/12 19:33, Brock Pytlik wrote:
On 02/01/12 18:41, Shawn Walker wrote:
On 02/01/12 17:56, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7136706-v1

Bugs:
7136706 pkg operation planning can traceback for unprivileged users if
conflict cache files don't exist
7140772 image._load_actdict can find of isn't set when expected

So, I have a test case for this attached. It's almost identical to the
test case for the other bug we discussed. It'd be great if you add it
/ verify it.

Your changes look right to me, although the wording of the synopsis
for the second one is a little awkward ("can find of" ?).

-Shawn
That test case doesn't cause this exception to be raised. It causes a

Yes, it does. Run it. I just did and it produces the traceback seen in 7136706.

Here's the tail of the traceback:

# | | File "/export/home/swalker/devel/pkg-alt/proto/root_i386/usr/lib/python2.6/vendor-packages/pkg/client/imageplan.py", line 1936, in __find_all_conflicts
# | |     offset_dict = self.image._load_actdict()
# | | File "/export/home/swalker/devel/pkg-alt/proto/root_i386/usr/lib/python2.6/vendor-packages/pkg/client/image.py", line 3548, in _load_actdict
# | |     actdict, otimestamp = self._create_fast_lookups()
# | | TypeError: 'NoneType' object is not iterable

As I mentioned in my off-list reply, this test case is *almost* identical to the other one.

The difference between the two is in the other one, I remove the /var/pkg/cache/publisher, in this one, I remove /var/pkg/cache.

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to