On 02/01/12 19:33, Brock Pytlik wrote:
On 02/01/12 18:41, Shawn Walker wrote:
On 02/01/12 17:56, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7136706-v1
Bugs:
7136706 pkg operation planning can traceback for unprivileged users if
conflict cache files don't exist
7140772 image._load_actdict can find of isn't set when expected
So, I have a test case for this attached. It's almost identical to
the test case for the other bug we discussed. It'd be great if you
add it / verify it.
Your changes look right to me, although the wording of the synopsis
for the second one is a little awkward ("can find of" ?).
-Shawn
That test case doesn't cause this exception to be raised. It causes a
different traceback addressed by 7136705 (which is out for review and
includes that test case). The traceback in the bug can only happen if
a) 3 temporary files are created b) the 3 temporary files can be
removed c) an exception happens after the 3 temporary files are
created but before exiting that try block. I couldn't figure a way to
construct a test that did this in the test suite. I was able to
produce this exception by, for example, typoing a print command that
caused a traceback in the appropriate place. If you have an idea for
how to create such a scenario in the test suite, please let me know.
Short of adding a debugging flag solely to raise an exception in one
test case, something neither I nor Danek thought was reasonable, I'm
stumped.
Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
I realized on the drive home that there's another way to trigger this
stack trace. One of the renames would need to throw an EnvironmentError
that wasn't an EACCES or EROFS. I don't see how to make that happen
either, but it seems like it might be slightly more possible than
satisfying the other set of conditions.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
