Brock Pytlik wrote: > On 02/07/12 13:09, Danek Duvall wrote: > >Brock Pytlik wrote: > > > >>https://cr.opensolaris.org/action/browse/pkg/bpytlik/7136706-v2 > >image.py: > > > > - line 26: why not in alphabetical order with the rest of the imports? > oops, b/c that's a debugging import which should be removed
It's not; you use it later, calling sys.exc_info(). > > - line 3505: I don't understand why you're getting rid of the > > KeyboardInterrupt handling? You don't have to return actdict if the > > unlinks fail and we got here for other reasons, but I think if we hit a > > ^C at this point, we actually want it to take effect. > I got rid of the special handling because now we always reraise the > original exception. I couldn't see any reason to have > if isinstance(e, KeyboardInterrupt): > raise > raise Yes, thank you for the extra boot to the head. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
