On Fri, Jul 13, 2012 at 03:08:02PM -0700, Danek Duvall wrote:
> Edward Pilatowicz wrote:
>
> > it seems like the output from the pkg command is not being localized at
> > all and i'm not sure why this is happening...
>
> Do you have package-manager installed?  For some reason, the .mo files are
> packaged there, and not in pkg, and I'll bet that the testsuite doesn't do
> anything to pick up localizations from the proto area instead of the
> system.
>

i have package-manager, but i don't have any .mo files delivered via
this package.  looking at the manifest i see why:
---8<---
edp@mcescher$ pkg contents -m package/pkg/package-manager | grep ^file | grep 
facet | grep ja
file ... facet.locale.ja=true ... 
path=usr/share/gnome/help/package-manager/ja/package-manager.xml ...
file ... facet.locale.ja=true ... path=usr/share/locale/ja/LC_MESSAGES/pkg.mo 
pkg.csize=87713 ...
file ... facet.doc.man=true facet.locale.ja_JP=true ... 
path=usr/share/man/ja_JP.UTF-8/man1/packagemanager.1 ...
file ... facet.locale.ja=true ... owner=root 
path=usr/share/omf/package-manager/package-manager-ja.omf ...
file ... facet.locale.ja=true ... owner=root 
path=usr/share/locale/ja/LC_MESSAGES/pkg.mo pkg.csize=87141 ...
---8<---

it seems like i also need to have the facet.locale.ja=true facet set.  :/
once i set that that facet (and update the test as previously mentioned
to fix the coverage bug) the test passes.

so is it considered user error that i only set "facet.locale.ja_JP" and
not "facet.locale.ja"?

wrt the coverage issue, i could push the following delta to fix it:
---8<---
description:
7166082 pkg command does not handle Japanese character encoding on Solaris 11 
(fix coverage)

modified:
   src/tests/cli/t_pkg_help.py

diff --git a/src/tests/cli/t_pkg_help.py b/src/tests/cli/t_pkg_help.py
--- a/src/tests/cli/t_pkg_help.py
+++ b/src/tests/cli/t_pkg_help.py
@@ -99,7 +99,8 @@ class TestPkgHelp(pkg5unittest.CliTestCa
                 # in the future then this test case will also need to be
                 # modified.

-                ret, out = self.cmdline_run("/usr/bin/locale -a", out=True)
+                ret, out = self.cmdline_run("/usr/bin/locale -a", out=True,
+                    coverage=False)
                 line = " ".join(out.split())
                 m = re.search(r"ja_JP.eucJP", line)
                 self.assert_(m, "You must have ja_JP.eucJP"
---8<---
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to