Edward Pilatowicz wrote:

> so is it considered user error that i only set "facet.locale.ja_JP" and
> not "facet.locale.ja"?

I guess for now, yeah.  I assume most of us haven't run into this because
we haven't faceted out the locales.

> wrt the coverage issue, i could push the following delta to fix it:
> ---8<---
> description:
> 7166082 pkg command does not handle Japanese character encoding on Solaris 11 
> (fix coverage)
> 
> modified:
>    src/tests/cli/t_pkg_help.py
> 
> diff --git a/src/tests/cli/t_pkg_help.py b/src/tests/cli/t_pkg_help.py
> --- a/src/tests/cli/t_pkg_help.py
> +++ b/src/tests/cli/t_pkg_help.py
> @@ -99,7 +99,8 @@ class TestPkgHelp(pkg5unittest.CliTestCa
>                  # in the future then this test case will also need to be
>                  # modified.
> 
> -                ret, out = self.cmdline_run("/usr/bin/locale -a", out=True)
> +                ret, out = self.cmdline_run("/usr/bin/locale -a", out=True,
> +                    coverage=False)
>                  line = " ".join(out.split())
>                  m = re.search(r"ja_JP.eucJP", line)
>                  self.assert_(m, "You must have ja_JP.eucJP"
> ---8<---

Yeah, go ahead.

Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to