Saurabh Vyas wrote: > https://cr.opensolaris.org/action/browse/pkg/saurabhv/7168378-rev0/webrev/
The changes for 7168378 and 7168375 seem fine, though while you're there, on line 293 there needs to be a trailing space inside the string, so that it doesn't run together with "regexp" on the next line. You'll need to go edit the .po files, too, since this string has been translated. Luckily, it's an easy change, since "edit" hasn't been translated, and presumably the run-together words are only there in the English. But I'm a bit perplexed by the change for the broken pipe, as it's different than the EPIPE handling we have in the pkg client. Since you haven't put an evaluation into the bug, could you explain why you've chosen to fix the bug the way you did? Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
