A gentle reminder for this review.
This current webrev addresses fix for 7168378, 7168375.
Thanks in advance,
Saurabh
On 08/10/12 02:30 PM, Saurabh Vyas wrote:
Hi All,
After taking to Danek & Shawn, decided to take the same approach that
we have for rest of tools in IPS for SIGPIPE handling in pkgmogrify,
but this issue is not reproducible anymore in newer builds ! (thus I
closed CR 7182079 )
So this fix now addresses : CR 7168378, 7168375
Updated Webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/7168378-rev2/webrev/
Please let me know if you have any comments on this fix.
Thanks,
~Saurabh
On 07/25/12 12:36, Saurabh Vyas wrote:
Thanks Danek for your comments, more inline ......
On 07/24/12 11:16 AM, Danek Duvall wrote:
Saurabh Vyas wrote:
https://cr.opensolaris.org/action/browse/pkg/saurabhv/7168378-rev0/webrev/
The changes for 7168378 and 7168375 seem fine, though while you're
there,
on line 293 there needs to be a trailing space inside the string, so
that
it doesn't run together with "regexp" on the next line.
Done.
You'll need to go
edit the .po files, too, since this string has been translated. Luckily,
it's an easy change, since "edit" hasn't been translated, and presumably
the run-together words are only there in the English.
Done.
The only problem that I see here : we have reference to the line no
where we have these english-msg-string that are being localized.
But these line no go out of sync as we add / delete code (with various
bug fixes).
So do we need to update the line no in these po files to keep the
references up-to-date........ or should we ignore these line no ref.
For now I have only put the lines no corresponding the msg string
that I have touched.
Updated webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/7168378-rev1/webrev/
But I'm a bit perplexed by the change for the broken pipe, as it's
different than the EPIPE handling we have in the pkg client. Since you
haven't put an evaluation into the bug,
Ah ! I have updated the evaluation field now.
could you explain why you've chosen
to fix the bug the way you did?
Well I see that SIGPIPE handling is deferred and while we have many line
to be written in PIPE, but the read end is closed (after reading 10
lines ) and we get EPIPE.
Thus we need to change the default action on SIGPIPE to SIG_DFL
Please let me know your comments on this fix.
HTH,
Saurabh
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
--
Saurabh Vyas
Solaris Install Group,
Revenue Product Engineering (RPE), Systems |Bangalore |
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
