On 08/02/12 15:24, Dan Price wrote:
Hi,
Here's a review for one more bug I want to fix in the
progress/printengine stuff. The fix here is again quite small-- in
short, we are switching away from using os.isatty(filehandle.fileno())
to filehandle.isatty(). This should fix the problems induced in the
install gate.
The rest of the fix is devoted to hooking up more testing infrastructure
related to printengine and progress tracking. The nice upside is that
the 'interactive' test utilities I added, runprogress and runprintengine,
now have test coverage.
https://cr.opensolaris.org/action/browse/pkg/dp/pkg-install-fix
src/tests/cli/t_pkg_terminal.py:
lines 67, 120: two newlines after class definitions
lines 72, 74: s/python/python2.6/
lines 77-78: unnecessary
lines 116-119: appears to be copy paste of runprog case; needs fixing
for runprint
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
