On 08/02/12 15:24, Dan Price wrote:
Hi,
Here's a review for one more bug I want to fix in the
progress/printengine stuff. The fix here is again quite small-- in
short, we are switching away from using os.isatty(filehandle.fileno())
to filehandle.isatty(). This should fix the problems induced in the
install gate.
The rest of the fix is devoted to hooking up more testing infrastructure
related to printengine and progress tracking. The nice upside is that
the 'interactive' test utilities I added, runprogress and runprintengine,
now have test coverage.
https://cr.opensolaris.org/action/browse/pkg/dp/pkg-install-fix
Thanks,
-dp
printengine.py:
51: I don't think "PrintEngineException" should be in this string, or
this shouldn't be an API exception. The expectation of error messages
for API exceptions is that they can/will be presented to the user, so
including that kind of internal only info doesn't seem appropriate to me.
104: Could this error message be more helpful to a user? I guess if I
saw this, I'm not sure what I'd do to correct things.
311: Debugging leftover?
progress.py:
61: Same comment about ProgressTrackerException
2114,2115: Same comment as line 104 in printengine.py
2124,2125: Do we not care about windows any more, or is this somehow
covered in the existing code in a way I don't understand?
The rest lgtm,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
