On Fri 07 Sep 2012 at 06:58PM, Dan Price wrote: > I've been working on a small project to: > > - Extend the nasty depot to be more nasty and more configurable. > - Enable the test suite to launch nasty depots. > - Extend the test suite with the ability to run nasty-depot based stress > tests. > - File and fix bugs in the core code identified by this testing.
I'm back! With what I hope is a finalized version of this work. > 7192182 pkgrecv traceback trying to setup request headers on a refetch > 7192183 nasty depot testing should be part of core testing > 7192447 transport.py has bad exception handling in do_search > 7193408 variable name incorrect in error path when getting a p5i > 7193416 client can traceback if manifest response is empty > 7195048 contents -g can traceback if a temporary publisher has problems > 7195051 catalog.attrs code needs improved armor against bogus responses > 7195083 p5i.parse should discriminate "" versus None This review has expanded somewhat-- I have added two new fixes: 7195369 corrupt manifests can end up on disk when -g is used This solves a couple of disjoint issues with the -g (temporary publisher) code, and adds in additional validation in the code and the testsuite to help ensure that we don't hit these problems again. Thanks to Shawn who did the heavy lifting on the core part of this fix. 7201323 catalog.extract_matching_fmris() could go away Some code consolidation that we noticed was expedient. The new review is posted at https://cr.opensolaris.org/action/browse/pkg/dp/nasty-testing-2/ The review contains four sub-reviews: webrev.main -- contains everything, including what is listed below. I've also included webrevs for the less trivial correctness fixes, for ease of review. webrev-catalog-armor -- 7195051 catalog.attrs code needs improved... webrev-catalog-codereduction -- 7201323 catalog.extract_matching_fmris() ... webrev-dashg -- 7195369 corrupt manifests can end up on disk when -g is ... Thanks, -dp -- Daniel Price, Solaris Kernel Engineering _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
