On Mon 01 Oct 2012 at 12:42PM, Shawn Walker wrote:
> >The new review is posted at
> >
> >https://cr.opensolaris.org/action/browse/pkg/dp/nasty-testing-2/
>
> webrev-catalog-armor/src/modules/catalog.py:
> line 1114: it would be preferable to make DEFAULT_ELEMS private '__'
>
> line 1259: s/Built/Build/ ?
Done.
> webrev-catalog-armor/src/modules/client/transport/transport.py:
> line 764: drop the parens
Done.
> webrev-catalog-armor/src/tests/api/t_catalog.py:
> general: missing space after 'print >>'
>
> line 1422: Docstring needs updating; exception raised is different
Done.
> webrev-dashg:
> general: I noticed you used an '_' for the DebugValue instead of a
> '-'; uncertain what the expected convention is.
I saw this comment from you earlier-- and so I surveyed them and _ seems
to outweigh -. I guess someone should make them all consistent at some
point... but not this changeset :)
> webrev.main/src/depot.py:
> lines 368, 370-372: These should be doubly unnecessary; ValueError
> is already caught at 506-508 and the Config class will also verify
> that the provided value is a valid number.
Fixed.
> webrev.main/src/tests/cli/t_pkg_nasty.py:
> general: missing space after 'print >>'
Fixed. Thanks!
-dp
--
Daniel Price, Solaris Kernel Engineering
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
