On 09/28/12 15:02, Dan Price wrote:
On Fri 07 Sep 2012 at 06:58PM, Dan Price wrote:
I've been working on a small project to:
- Extend the nasty depot to be more nasty and more configurable.
- Enable the test suite to launch nasty depots.
- Extend the test suite with the ability to run nasty-depot based stress
tests.
- File and fix bugs in the core code identified by this testing.
I'm back! With what I hope is a finalized version of this work.
7192182 pkgrecv traceback trying to setup request headers on a refetch
7192183 nasty depot testing should be part of core testing
7192447 transport.py has bad exception handling in do_search
7193408 variable name incorrect in error path when getting a p5i
7193416 client can traceback if manifest response is empty
7195048 contents -g can traceback if a temporary publisher has problems
7195051 catalog.attrs code needs improved armor against bogus responses
7195083 p5i.parse should discriminate "" versus None
This review has expanded somewhat-- I have added two new fixes:
7195369 corrupt manifests can end up on disk when -g is used
This solves a couple of disjoint issues with the -g (temporary
publisher) code, and adds in additional validation in the code and the
testsuite to help ensure that we don't hit these problems again.
Thanks to Shawn who did the heavy lifting on the core part of this
fix.
7201323 catalog.extract_matching_fmris() could go away
Some code consolidation that we noticed was expedient.
The new review is posted at
https://cr.opensolaris.org/action/browse/pkg/dp/nasty-testing-2/
webrev-catalog-armor/src/modules/catalog.py:
line 1114: it would be preferable to make DEFAULT_ELEMS private '__'
line 1259: s/Built/Build/ ?
webrev-catalog-armor/src/modules/client/transport/transport.py:
line 764: drop the parens
webrev-catalog-armor/src/tests/api/t_catalog.py:
general: missing space after 'print >>'
line 1422: Docstring needs updating; exception raised is different
webrev-dashg:
general: I noticed you used an '_' for the DebugValue instead of a
'-'; uncertain what the expected convention is.
webrev.main/src/depot.py:
lines 368, 370-372: These should be doubly unnecessary; ValueError
is already caught at 506-508 and the Config class will also verify
that the provided value is a valid number.
webrev.main/src/tests/cli/t_pkg_nasty.py:
general: missing space after 'print >>'
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
