Hi there,

I've a code review here that fixes:

15875724 pylint update broke the build

Full details are in the bug report, but the short summary is that because pylint moved from 0.18.0 -> 0.25.2, and the format of the "disable-msg" comment changed, we started getting lots of lint errors which caused the build to tip over.

I've fixed all of these, along with the new lint errors that were also thrown, and made a Makefile/setup.py change to ensure that we don't try to run pylint on systems that don't have pylint 0.25.2

There's a webrev at:

https://cr.opensolaris.org/action/browse/pkg/timf/pylint-fixes/pylint-fix-pkg-webrev

comments would be most welcome,

        cheers,
                        tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to