On 11/14/12 22:03, Tim Foster wrote:
Hi there,
I've a code review here that fixes:
15875724 pylint update broke the build
Full details are in the bug report, but the short summary is that
because pylint moved from 0.18.0 -> 0.25.2, and the format of the
"disable-msg" comment changed, we started getting lots of lint errors
which caused the build to tip over.
I've fixed all of these, along with the new lint errors that were also
thrown, and made a Makefile/setup.py change to ensure that we don't try
to run pylint on systems that don't have pylint 0.25.2
There's a webrev at:
https://cr.opensolaris.org/action/browse/pkg/timf/pylint-fixes/pylint-fix-pkg-webrev
For the record, the disable changes were actually introduced in pylint
0.21.0. But since this is a require check to run the tests, 0.25.2 is
safer since you know it actually works :-)
And of course, 0.26.0 was just released about a week ago.
Also, it would still be nice to have an environment override to silently
skip the pylint step. Something like 'PKG_PYLINT'.
src/Makefile:
If pylint isn't installed, will this cause the build to fail? I'd
hope that it would fail the same as if we didn't have the required
version -- it would just warn.
Otherwise, LGTM.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
