On 11/16/12 06:38 AM, Shawn Walker wrote:
On 11/14/12 22:03, Tim Foster wrote:
https://cr.opensolaris.org/action/browse/pkg/timf/pylint-fixes/pylint-fix-pkg-webrev
For the record, the disable changes were actually introduced in pylint
0.21.0. But since this is a require check to run the tests, 0.25.2 is
safer since you know it actually works :-)
Sure.
And of course, 0.26.0 was just released about a week ago.
:-)
Also, it would still be nice to have an environment override to silently
skip the pylint step. Something like 'PKG_PYLINT'.
That's a good idea. I'll use $PKG_PYLINT_SKIP just so it's clear what
the environment variable does. I think it's still worthwhile to warn
that pylint isn't being run here, just so it's captured in the logs.
src/Makefile:
If pylint isn't installed, will this cause the build to fail? I'd
hope that it would fail the same as if we didn't have the required
version -- it would just warn.
Oops, thanks for catching that - we actually blew up when no version of
pylint was installed, not in Makefile, but in setup.py where we tried to
do essentially 'int("")' which raised a ValueError.
I've changed setup.py to deal with empty version strings, warn about not
running pylint, and drive on with the rest of the build. This should be
a rare occurrence, since pkg:/developer/opensolaris/pkg5 has a
dependency on pylint.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
