jgrulich added inline comments.
INLINE COMMENTS
> main.qml:77
> id: handler
> - onWirelessScanTimerEnabled: {
> - if (enabled) {
I wonder whether the timer in the applet itself should be running if we fail to
scan, I think it should be stopped when we fail and resumed again when a
successful scan was done. If I do get it correctly and we fail to do a scan, we
schedule a new one in e.g. 5 seconds, after 5 seconds we perform a successful
one, but after another 5 seconds this timer will perform a new one and fail
again. Stopping this timer when we fail to scan and resuming it later will
result into higher ration of successful scans, am I right?
> handler.cpp:552
> +{
> + QTimer *timer;
> + if (!m_wirelessScanRetryTimer.contains(interface)) {
This timer never gets deleted.
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
arcpatch-D23578
REVISION DETAIL
https://phabricator.kde.org/D23578
To: meven, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
