meven added inline comments. INLINE COMMENTS
> meven wrote in main.qml:77 > I removed this because > > 1: > Request scan failure should never happen anymore because the handler makes > sure never to call requestScan too often. > The timer can just constantly ask for request scans it does not impact the > "real" requestScan sent. > > 2: > Now the scans are per interface, meaning we check the interface states by > interface and they could have different state. > It does not match well with this timer : if an interface fails, should we > stop to scan the others ? I believe not. > A solution would be to have timer by interface, but we already have this in > the handler anyway so it seems overkill to do it here. @jgrulich Any feedback ? You approved this a while back but we still have this point to deal with. REPOSITORY R116 Plasma Network Management Applet BRANCH arcpatch-D23578 REVISION DETAIL https://phabricator.kde.org/D23578 To: meven, #plasma, jgrulich Cc: plasma-devel, crossi, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
