jgrulich added inline comments. INLINE COMMENTS
> jgrulich wrote in main.qml:77 > I wonder whether the timer in the applet itself should be running if we fail > to scan, I think it should be stopped when we fail and resumed again when a > successful scan was done. If I do get it correctly and we fail to do a scan, > we schedule a new one in e.g. 5 seconds, after 5 seconds we perform a > successful one, but after another 5 seconds this timer will perform a new one > and fail again. Stopping this timer when we fail to scan and resuming it > later will result into higher ration of successful scans, am I right? What about this? > meven wrote in handler.cpp:552 > timer will be one of the value of hash m_wirelessScanRetryTimer, which are > cleaned line 516. > I could be missing a delete there though such as `delete > m_wirelessScanRetryTimer.remove(interface)` You remove it just from the map, but it doesn't get deleted, you would need to do something like delete m_wirelessScanRetryTime.take(interface); REPOSITORY R116 Plasma Network Management Applet BRANCH arcpatch-D23578 REVISION DETAIL https://phabricator.kde.org/D23578 To: meven, #plasma, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
