> On 2010-04-07 15:16:04, Marco Martin wrote: > > don't think it's the right approach. > > we should probably have easing curve support for our animations that are > > directly qabstractanimations > > igorto wrote: > so you suggest create our own easing curvers for special animations like > that? > > Marco Martin wrote: > well, not our own, the standard ones if possible
Yes; while I think that having easing curve support only in QVariantAnimation is a bit of a design flaw in Kinetic (it probably should have been in QAbstractAnimation), but if this animation becomes a QVariantAnimation then we get easing curves "for free" and then this patch isn't necessary (just throw it an appropriate easing curve). - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3513/#review4909 ----------------------------------------------------------- On 2010-04-07 14:56:43, Bruno Abinader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3513/ > ----------------------------------------------------------- > > (Updated 2010-04-07 14:56:43) > > > Review request for Plasma, igorto and Adenilson Cavalcanti. > > > Summary > ------- > > A new property "isBounceable" is added to the Rotation animation, which > causes the target widget to "bounce" on a range between (-angle()/2, > angle()/2). A static number of steps is defined by default (10 steps), > causing the bounce angle to decrease through the animation steps. Notice that > this effect doesn't behaves properly when the animation is part of a group, > falling back to the "non-bounceable" behavior when it is part of a group. > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/animations/rotation_p.h 1111462 > trunk/KDE/kdelibs/plasma/animations/rotation.cpp 1111462 > > Diff: http://reviewboard.kde.org/r/3513/diff > > > Testing > ------- > > Tests have been made for different angles/axis on an additional example > button on the animation plasmoid example. This example code is not yet > release, but I can kindly pastebin it if needed. > > > Thanks, > > Bruno > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel