cblack added inline comments. INLINE COMMENTS
> broulik wrote in ChangePassword.qml:67 > How does that work? Holdover from an older version. You can look through the history of https://invent.kde.org/cblack/userkcm-ng/ to see when it actually worked. > broulik wrote in user.cpp:189 > Can you make this async? Make an `ApplyJob`, maybe? You're doing four > blocking calls in a row, which may also spawn a polkit prompt? I don't really know how to do async stuff in this context, you would probably have to show me how/link examples. > broulik wrote in user.h:59 > Clever, not having a `READ` but I think it's mandatory? QML doesn't seem to complain, soo.... ¯\_(ツ)_/¯ REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
