----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/#review45636 -----------------------------------------------------------
mediaelements/mediawelcome/HomeScreenFooter.qml <http://git.reviewboard.kde.org/r/114429/#comment32596> Please document why the interval is '300000'. mediaelements/mediawelcome/HomeScreenFooter.qml <http://git.reviewboard.kde.org/r/114429/#comment32594> Please fix the formatting and coding style. mediaelements/mediawelcome/HomeScreenText.qml <http://git.reviewboard.kde.org/r/114429/#comment32595> If this is not required then please remove it. - Vishesh Handa On Dec. 13, 2013, 7:07 a.m., Heena Mahour wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114429/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2013, 7:07 a.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Replaced Text{} by Label {} > Time Data engine instead of creating Date() and hours -> less code ! > text color is predefined in Label {} > > > Diffs > ----- > > mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 > mediaelements/mediawelcome/CategoriesListDelegate.qml f011bae > mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 > mediaelements/mediawelcome/HomeScreenText.qml 35cd20a > > Diff: http://git.reviewboard.kde.org/r/114429/diff/ > > > Testing > ------- > > yeah ,works fine ,displays days as well now. > > > Thanks, > > Heena Mahour > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
