> On Dec. 13, 2013, 3:49 p.m., Aaron J. Seigo wrote: > > magical :) > > > > not for me to mark as "ship it", though; that's up to PMC people. > > > > one side note, though not related to this patch: the text on the main > > screen kind of SHOUTS at you with the large font size and multiple rows of > > text. could use a touch of typographic styling perhaps?
Aaron, that is something that I am concerned about as well. Though decreasing the point size is easy, I couldn't think of the best way (TM) to reduce it to one row. One option I see is get rid of the date altogether as I'd imagine someone watching videos to think "Hey I've been watching 3 movies in a go, wonder what time it is?" but I can't think of the same thing for the date. Opinions anyone? - Shantanu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/#review45659 ----------------------------------------------------------- On Dec. 13, 2013, 3:01 p.m., Heena Mahour wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114429/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2013, 3:01 p.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Replaced Text{} by Label {} > Time Data engine instead of creating Date() and hours -> less code ! > text color is predefined in Label {} > > > Diffs > ----- > > mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 > mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 > > Diff: http://git.reviewboard.kde.org/r/114429/diff/ > > > Testing > ------- > > yeah ,works fine ,displays days as well now. > > > File Attachments > ---------------- > > screenshot > > http://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/dfae9d60-ef6f-4562-a7e3-8f6c0d97a99e__pmc1.png > > > Thanks, > > Heena Mahour > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
