----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/#review45648 -----------------------------------------------------------
Still needs some finishing touches. Also, whenever you submit patches that change the UI, always put a screenshot in the review as well (I expect this in the next diff update). This helps in people to provide UI feedback even if they don't have time to apply the patch and run it themselves. mediaelements/mediawelcome/HomeScreenFooter.qml <http://git.reviewboard.kde.org/r/114429/#comment32608> Two things- 1. This code still isn't very readable, can you try writing the date and time logic on separate lines? 2. The seconds is irritating as it keeps drawing attention every second. Please remove it and keep only hour and minute. mediaelements/mediawelcome/HomeScreenText.qml <http://git.reviewboard.kde.org/r/114429/#comment32609> These changes aren't relevant to this review, please remove these. - Shantanu Tushar On Dec. 13, 2013, 2:18 p.m., Heena Mahour wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114429/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2013, 2:18 p.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Replaced Text{} by Label {} > Time Data engine instead of creating Date() and hours -> less code ! > text color is predefined in Label {} > > > Diffs > ----- > > mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 > mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 > mediaelements/mediawelcome/HomeScreenText.qml 35cd20a > > Diff: http://git.reviewboard.kde.org/r/114429/diff/ > > > Testing > ------- > > yeah ,works fine ,displays days as well now. > > > Thanks, > > Heena Mahour > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
