On Thu, Sep 24, 2009 at 11:13:05AM -0700, Alan Irwin wrote: > On 2009-09-24 16:19+0100 Andrew Ross wrote: > >> Alan, >> >> One consequence of your change is that long split lines for function >> definitions etc now indent at the beginning of the line rather than aligning >> on the brackets. Personally I don't like that. I'm trying to work out how >> to change this without breaking other things again. It's not entirely >> obvious. >> In the meantime I would prefer we don't propagate changes any further. It >> looks >> like line splitting is a can of worms. >> >> I've reverted to aligning function prototypes / definitions on the brackets, >> but >> left function calls for now since this was the source of some of the ugly >> long >> lines. > > Actually, to be technical if we keep line splitting turned off (which I > would highly advise for now) then this concern you have expressed is about > ugly indentation whitespace issues with no line splitting changes involved > at all. > > Perhaps you have found the correct style compromise already? Clearly, > aligning on left parentheses for continued long argument lists for every > function call generated some massive indentation that we don't want for > those cases where the function call's left parentheses was far to the right > on the line already. However, if you prefer a style of aligning on left > parentheses for prototypes/definitions that should not produce massive > indentation (unless there is a really long function name combined with a > long argument list) and that style inconsistency with how the functions are > called is fine with me since there are obviously different style needs in > the function call case versus prototypes/definitions case.
Alan, This is what I have done. > > Also, please do the consistency check I mentioned in my last post with the > uncrustify.cfg that I committed along with my last src changes. I would like > to put that consistency issue to rest if at all possible before you commit > more changes. I have noticed that you sometimes have to rerun uncrustify more than once where for example there are multiple changes to a line. The one I noticed was where a change in the indentation changed a comment on the end of the line. This did not alter the alignment of the rest of the comment on the subsequent lines. Presumably uncrustify does things in a certain set order. Rerunning uncrustify sorted out the comment alignment. So the moral seems to be to run uncrustify multiple times until things don't change any more. After that results should be consistent. I suspect this is what you saw. Andrew ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
