The styling of our C source code has been completed as of revision 10545 by registering all our C source code (found using 'find -name "*.[ch]*" |grep -v .svn |less') in scripts/style_source.sh and running 'scripts/style_source.sh --apply' repeatedly (sometimes 3 times were required) until no more styling changes were made by uncrustify. This has all been done with uncrustify version 0.53 (for which there is a specific version check in the script). I urge all with access to Unix platforms to download and install uncrustify version 0.53 and run the script before you commit to make sure our C style remains consistent. Note, the registration of source code has been done mostly with wild cards so future maintenance should be minimal (although necessary when new directories are being used).
I tested our re-styled C code with the -DBUILD_TEST=ON -DDEFAULT_ALL_DEVICES=ON cmake options and "make test_noninteractive". All seems well. However, that is obviously not a complete test so please be alert for any bugs this C styling effort may have introduced. Also, please look at all our C source code to make sure our current consistent style is something you can live with. The point is uncrustify is a powerful tool that can make C style almost anything we desire, but we may not have a clear idea what we desire until we see comprehensive results (as now). Anyhow, I am completely open to further C style iterations with a changed uncrustify.cfg if a consensus forms that further style changes are necessary. Since the above find command also finds all our C++ source code, I have registered that as well in the script to help Andrew, but commented it out for now until he can finalize his C++ styling plans. Andrew, once you have C++ styled according to uncrustify.cfg could you also use your emacs expertise to update plplot-c-style.el to be consistent with the styling done by uncrustify.cfg? plplot-c-style.el was taken from the Google SOC project and demonstrates how to control lots of different C/C++ style characteristics using emacs but the GSOC style is completely inconsistent with our style as enforced by uncrustify.cfg. Thus, some adjustments have to be made to plplot-c-style.el to make it at least not contradict the results from uncrustify as configured by our current uncrustify.cfg. I don't know how to make those adjustments myself, but I am hoping you do. Of course, if nobody here has sufficient emacs expertise to understand our current plplot-c-style.el, then we should just replace it with an extremely simple plplot-c-style.el that does so little that it does not contradict our current style. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
