Hi!

To get the ada binding build successfully with the latest svn trunk (12298) (at least on openSUSE 12.2 and higher), I used the attached patch. Please have a look and let me know what you think.

Thanks!
--
Atri

P.S.: Sorry for the top-post from a brain-dead web email client...


-----Original Message-----
From: Alan W. Irwin <ir...@beluga.phys.uvic.ca>
To: Hezekiah M. Carty <hezekiahca...@users.sourceforge.net>
Cc: PLplot development list <plplot-devel@lists.sourceforge.net>; Andrew Ross <andrewr...@users.sourceforge.net>; Hǎiliàng Wáng <hwang....@gmail.com>
Sent: Fri, Mar 15, 2013 11:40 am
Subject: Re: [Plplot-devel] Should line width thinner than 1.0 be supported?


On 2013-03-15 05:54-0400 Hezekiah M. Carty wrote:

On Tue, Jan 29, 2013 at 11:54 PM, Alan W. Irwin
<ir...@beluga.phys.uvic.ca> wrote:
@Hez: Because of my plwidth core changes, the OCaml bindings will
not build any more.  More details below.

To others here: use -DENABLE_ocaml=OFF for the svn trunk version
until further notice.


Thank you for going through most of the work required to update the
OCaml bindings.  I fixed the remaining binding issues with a commit
last night so the OCaml bindings should build properly now.

@Hez:
I confirm good OCaml results here with the test_noninteractive
target.  Thanks for completing my plwidth changes for OCaml!

@Everybody here:
It is recommended that you no longer specify -DENABLE_ocaml=OFF so
that our ocaml bindings build by default.  However, for some reason I
can no longer even build our Ada bindings because of type
inconsistencies concerning the plwidth changes so to get the above
good results I had to specify -DENABLE_ada=OFF

@Jerry:

After the previously discussed conversion to Allura (which should start
shortly),
will you please take a look at the type inconsistencies introduced into
our Ada bindings and examples by my plwidth changes?

Thanks in advance.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________

-------------------------------------------------------------------------
-----
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Index: plplot/bindings/ada/plplot.adb
===================================================================
--- plplot.orig/bindings/ada/plplot.adb
+++ plplot/bindings/ada/plplot.adb
@@ -71,7 +71,7 @@ package body PLplot is
     
     -- Set default pen width. Docs don't say, so I'll make it 1.
     -- I could make this depend on the type of outut device used.
-    Default_Pen_Width : constant Integer := 1;
+    Default_Pen_Width : constant Long_Float := 1.0;
     procedure Set_Default_Pen_Width is
     begin
         Set_Pen_Width(Default_Pen_Width);
@@ -3312,7 +3312,7 @@ package body PLplot is
 
     -- Set pen width.
     -- plwidth
-    procedure Set_Pen_Width(Pen_Width : Integer) is
+    procedure Set_Pen_Width(Pen_Width : Long_Float) is
     begin
         plwidth(Pen_Width);
     end Set_Pen_Width;
Index: plplot/bindings/ada/plplot.ads
===================================================================
--- plplot.orig/bindings/ada/plplot.ads
+++ plplot/bindings/ada/plplot.ads
@@ -2104,7 +2104,7 @@ package PLplot is
 
     -- Set pen width.
     -- plwidth
-    procedure Set_Pen_Width(Pen_Width : Integer);
+    procedure Set_Pen_Width(Pen_Width : Long_Float);
 
 
     -- Set up world coordinates of the viewport boundaries (2d plots).
Index: plplot/bindings/ada/plplot_traditional.adb
===================================================================
--- plplot.orig/bindings/ada/plplot_traditional.adb
+++ plplot/bindings/ada/plplot_traditional.adb
@@ -70,7 +70,7 @@ package body PLplot_Traditional is
     
     -- Set default pen width. Docs don't say, so I'll make it 1.
     -- I could make this depend on the type of outut device used.
-    Default_Pen_Width : constant Integer := 1;
+    Default_Pen_Width : constant Long_Float := 1.0;
     procedure Set_Default_Pen_Width is
     begin
         plwidth(Default_Pen_Width);
@@ -3147,7 +3147,7 @@ package body PLplot_Traditional is
 
 
     -- Set pen width.
-    procedure plwidth(Pen_Width : Integer) is
+    procedure plwidth(Pen_Width : Long_Float) is
     begin
         PLplot_Thin.plwidth(Pen_Width);
     end plwidth;
Index: plplot/bindings/ada/plplot_traditional.ads
===================================================================
--- plplot.orig/bindings/ada/plplot_traditional.ads
+++ plplot/bindings/ada/plplot_traditional.ads
@@ -1932,7 +1932,7 @@ package PLplot_Traditional is
 
 
     -- Set pen width.
-    procedure plwidth(Pen_Width : Integer);
+    procedure plwidth(Pen_Width : Long_Float);
 
 
     -- Set up world coordinates of the viewport boundaries (2d plots).

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to