On 2016-12-24 20:24-0500 Pedro Vicente wrote: > Hi Alan > >> Then collect those two files in a tarball using >> tar zcf wxwidgets_experimental_commits2.tar.gz 00* > > I did the git am as explained, and > wxwidgets_experimental_commits2.tar.gz > is attached > > examples/c/x01c -dev wxwidgets > and > test_wxPLplotDemo > > run with no problems on all my tests >
Hi Pedro: Thanks very much for that compiler warning fix and big testing effort on a Windows platform and 4 Linux platforms for this latest iteration of your two-commit fix. I tested this latest version here in the same way I did the previous iteration, and all was well. Now that we have such a widely tested solution, would you be willing to write a short summary paragraph concerning the changes in the plplotwxwidgets library API? I cannot write such a summary myself because I don't know the correct C++ terminology to use. That summary would likely help Phil make up his mind about whether we will adopt your latest iteration of the fix or try something else. However, please write that paragraph with a somewhat larger audience in mind than just Phil. Because if he decides to go with your fix, then I will want to include your summary paragraph in our release notes to aid those (like you and Greg Jung) who are developing their own applications and libraries that link with the plplotwxwidgets library and who will therefore have to change those applications and libraries to be compatible with our changes. So the summary should answer the question what is the minimum that an outside developer need to know about the the changes to the plplotwxwidgets library API? To help you figure out what to say, here is how to discover the changes since plplot-5.11.1 in the library API and our demo that links with that library: git diff --ignore-all-space plplot-5.11.1 bindings/wxwidgets/*.h git diff --ignore-all-space plplot-5.11.1 examples/c++/wxPLplotDemo.cpp Obviously, the extra include to allow for the possibility of debugging output in bindings/wxwidgets/wxPLplotstream.h is not an API change, but it looks like there have been substantial backwards-incompatible changes in the plplotwxwidgets library API as indicated by the changes in bindings/wxwidgets/wxPLplotwindow.h. Those API changes appear also to be confirmed by that second git diff result above (although some of those changes were an addition of a locate mode and nothing to do with API changes so your summary doesn't need to mention that locate mode addition). Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
