On Mar 2, 2009, at 6:18 AM, Carsten Ziegeler wrote:
Hi,
I'm currently trying to add portlet support to Apache Sling by using
our
2.0 implementation.
One thing that strikes me is the use of packages in the various
modules.
In order to have a clear separation and to easily support OSGi (where
there's no package overlap between modules), I think we should change
the following:
container-api:
- The api currently contains packages like core and internal which do
not sound like api packages. The "internal" stuff (request/response
impl) are used in the spi, so I think we should move it to the spi
package.
- "core" contains the NullPortlet and the PortletServlet. The
NullPortlet is only used inside the PortletServlet, so we should make
this an inner class and not expose it. The PortletServlet could move
to
a different package, something like "servlet".
container:
- The container should not use the org.apache.pluto package. We should
move the PortletContainerFactory class to the core or the util package
- Core contains the o.a.p.util package which is already taken by the
pluto-utils (which makes sense), so we shoud move this to another
package.
- To have the best separation possible, we could move all container
stuff (impl) to o.a.p.container.*, but maybe this change is too much?
If noone objects, I'll do the obvious changes.
WDYT?
Sounds good, but we should wait on Ate before starting this work as I
believe he has some big outstanding commits....
