Hi, Ate Douma wrote: > First of all, I think all your proposed changes are fine by me. > But, I'd prefer if you can hold off these changes a few more days? yes, sure.
> As a matter of fact, some of your recent changes I already had taken > care of myself too ;) :) > Now, my changes will result in quite some SPI usage changes, and for > instance I could remove almost all the *Internal* interfaces (now only > needing the Portlet 2.0 request/response interfaces itself), and no more > "wrapping" or "blending" of the portlet and servlet interfaces. Cool! > As such, I planned to commit my changes to a separate branch this week > so everyone can review the effect of all this, before I would merge it > back into trunk. Hmm, I'm not against that - but I think you could easily directly commit to trunk; noone objected the proposed changes. > I've encountered a small problem however: I broke my elbow this Sunday > at a soccer game and because of that I'm stuck with an immobilized left > arm for the next 2 weeks :( Args, get well soon! > <SNIP/> > Anyway, as you can understand from the above, I'd rather wait with your > proposed repackaging changes until we've gone through the above > transition, otherwise merging will become extremely difficult thereafter. Yes, sure - I can wait :) > I've already had difficulty validating/merging your recent changes as > the meat of those are formatting changes only but with some real changes > embedded. It would be nice if you can separate those 2 different types > of changes in individual commits? Ah, yes, sorry for that - it's (again) this nice save action functionality from Eclipse which performs some formatting as soon as you save - I always forget to turn this off :( Carsten -- Carsten Ziegeler [email protected]
