Vincent wrote on 2013-12-31: > On 30/12/2013 12:21, O. Hartmann wrote:
> I do not think so. I think "@libdir@/" is right in the general case. > Packagers that will install pocl in multiarch system directory can > very easily patch the icd file. In my opinion, no need to add > complexity (configure option) in upstream code for such a particular > use case. Ok. > > I'm quite sure that the concept in POCL is right, but I need to find > > out why the ports framework of FreeBSD's ports system is bumping the > > version number up again. > > I agree here. The .so filename should only be used for (direct) > linking with a shared library. In debian, lintian complains when .so > files are added into a library package that is not a development > package (-dev). This I didn't know, but now the comment in that commit makes sense :) So a non-development Debian package of pocl doesn't even have a file (link) named libpocl.so? But (putting on the pocl release manager hat) this seems to be a strictly packaging issue - when a user is compiling pocl themselves, having only libpocl.so in the .icd file seems to work on all platforms tested thus far. > In the Debian package, it will be the SONAME as I do not see any > reason to change the icd file when the pocl library is upgraded into > a compatible version. But the icd file will be patched (to remove > @libdir@) so I can change this too. When developing, it can be better > to have the full name to know which version of pocl is really used. > I've no strong opinion here. So I think what we need to do is to set the .icd to not have the SONAME, but just the .so link. And add a note to README.packaging. Would it be useful to store these sort of patches (i.e. removal of the @libdir@ and adding of .VER) in the pocl source tree or is it better to keep them in the package build setups? kalle ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ pocl-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pocl-devel
