On 31/12/2013 11:33, Kalle Raiskila wrote: > Vincent wrote on 2013-12-31: > >> On 30/12/2013 12:21, O. Hartmann wrote: > >>> I'm quite sure that the concept in POCL is right, but I need to find >>> out why the ports framework of FreeBSD's ports system is bumping the >>> version number up again. >> >> I agree here. The .so filename should only be used for (direct) >> linking with a shared library. In debian, lintian complains when .so >> files are added into a library package that is not a development >> package (-dev). > > This I didn't know, but now the comment in that commit makes sense :) > So a non-development Debian package of pocl doesn't even have a file > (link) named libpocl.so?
Yes. There should be no reason to have one. And, for libpocl, the libpocl.so is never used (applications link against the ICD loader, ie libOpenCL.so). But libpoclu.so will be provided only in the development package for example. That said, due to error or bad design, there can be exceptions. The bad SONAME of Intel OpenCL ICD Loader explain why I keep the libOpenCL.so into the library package for now ( http://bugs.debian.org/679228 ) I will probably remove it soon. > But (putting on the pocl release manager hat) this seems to be a > strictly packaging issue - when a user is compiling pocl themselves, > having only libpocl.so in the .icd file seems to work on all > platforms tested thus far. Yes. But I really think it is a better design to not use the .so file for the runtime (ie it is better to put the SONAME or the full name into the .icd file) That said, I agree with you : putting the .so file will work. It is just that .so files are not designed to be used at runtime. > Would it be useful to store these sort of patches (i.e. removal of the > @libdir@ and adding of .VER) in the pocl source tree or is it better to > keep them in the package build setups? Debian (and all derivatives) have a place in their packaging system (debian/patches/). It is probably more useful to add an URL to theses patches for other distributions (rpm, ...). Note that a distribution without multiarch does not really need to change this file (but if the .so file is referenced in the .icd file and the .so file is put in a -dev package) Regards, Vincent ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ pocl-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pocl-devel
