On Mon, 2014-03-31 at 11:25 +0200, Uli Zappe wrote:
> I attach the patch file to this mail.

        Hello,
thanks for the re-send. I see that your changes are quite the same as
those at [r1586]. Could you try with them, please?

That revision does not contain the change in CMakeLists.txt for
PODOFO_VERSION_PATCH, but that's most likely only a typo in the released
tarball. The trunk code has this version already updated to "3".

I also do not quite understand the addition of expat and bzip2
libraries. Is it, because the fontconfig you use requires it? If it's
so, then the right change may come to fontconfig, to extend its own libs
(similar to `pkg-config --libs fontconfig` command, alternatively for
freetype libs). That way it'll start to work for any other project too,
instead of patching each individual project which uses
fontconfig/freetype.

The LUA related changes: I see the lua_open() had been replaced in LUA
5.1, and lua_rawlen() had been introduced in version 5.2. I'd say, to
keep backward compatibility, it'll be good to conditional-compile the
code based on the used LUA version, rather than replace the functions. 

        Bye,
        zyx

[r1586] http://sourceforge.net/p/podofo/code/1586 

-- 
http://www.litePDF.cz                                 i...@litepdf.cz


------------------------------------------------------------------------------
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to