Hi Jeff, hi PoDoFo developers,
thanks, Jeff, just one little thing is left:
I have attached a patch to this e-mail to correct
the encoding names in the documentation comments
for the Unicode conversion tables for the new encodings.
Could a committer please review, apply and commit it
separately to the public repository?
Best regards, mabri
________________________________
From: Josef Rokos <p...@bukova.info>
To: podofo-users@lists.sourceforge.net
Sent: Monday, 25 April 2016, 10:09 UTC
Subject: Re: [Podofo-users] Patches for font encoding and digital signatures
Hi,
yes it is ok. My mistake, sorry.
J. Rokos
On Thu, Apr 21, 2016 at 5:07 PM, zyx <z...@litepdf.cz> wrote:
On Wed, 2016-04-20 at 16:07 +0000, Matthew Brincke wrote:
>> There are some bad spelling mistakes in it ("Cerifiacion" instead of
>> the correct "Certification"), so could you (zyx) please commit the
>> patch I have attached to correct them?
>
> Hi,
>thanks for the patch, I overlooked the typo during the review. My
>fault. I committed your patch as revision 1708:
>http://sourceforge.net/p/podofo/code/1708
>
>> Because it was only committed less than 3 days ago, AFAICS nobody
>> should already rely on them (Josef, I hope you are OK with spelling
>> your calls to the new API correctly?).
>
>No problem with this, it's still in the development version only, which
>was not released yet, thus it's still safe to do such changes in the
>new API functions/methods/variables...
>
> Thanks again and bye,
>
> zyx
>
>--
>http://www.litePDF.cz i...@litepdf.cz
>Index: src/base/PdfEncoding.h
===================================================================
--- src/base/PdfEncoding.h (revision 1714)
+++ src/base/PdfEncoding.h (working copy)
@@ -767,7 +767,7 @@
virtual const pdf_utf16be* GetToUnicodeTable() const;
private:
- static const pdf_utf16be s_cEncoding[256]; ///< conversion table from ZapfDingbatsEncoding to UTF16
+ static const pdf_utf16be s_cEncoding[256]; ///< conversion table from Win1250Encoding to UTF16
};
/**
@@ -797,7 +797,7 @@
virtual const pdf_utf16be* GetToUnicodeTable() const;
private:
- static const pdf_utf16be s_cEncoding[256]; ///< conversion table from ZapfDingbatsEncoding to UTF16
+ static const pdf_utf16be s_cEncoding[256]; ///< conversion table from Iso88592Encoding to UTF16
};
}; /* namespace PoDoFo */
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
