On Thu, 2018-10-18 at 17:43 -0500, Clayton Wheeler wrote:
> Does this seem sensible?

        Hi,
the idea sounds good, but the patch doesn't compile. I guess you made
some changes just before creating the patch, but you didn't compile the
code, because otherwise you'd notice it.

There's also a little typo in your comment, specifically here:
+        // Per the PDF spec, section 7.5.5, the ID shall be an indirect object.

I'd also remove debugging stuff from the test code, those comments like
this one:
+    //std::cerr << inBuf;
also because once someone enables it the code will not compile (again).

Would you mind to correct the patch, please?
        Thanks and bye,
        zyx




_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to