Hi,
On Fri, 2019-01-18 at 01:13 +0100, Matthew Brincke wrote:
> More importantly, this patch seems to depend on [PATCH 4/5] in
> this series for correctness (to avoid a memory leak) because...
this is what I dislike on patch series the most. Even when one does
patch review in "correct order", he/she can find issues and report
them, then realize it had been fixed in the next patch. That's a plain
waste of time and, which is worst, it introduces unneeded broken state
of the repository (ideally, repository at any commit should be
buildable and without known bugs). The difference between overlooked
bugs and known bugs is that all the changes in the proposal add new
code, thus it should provide consistent code, not intentionally
partially broken.
Nonetheless, that's only my personal experience with patch reviews and
an off-topic for this mailing list.
Bye,
zyx
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
