-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Thomas Johnson wrote: > Hi Loic, > > I was finally able to figure out how to write the tests. I have attached the > patches. Please let me > know if these are suitable. >
Hi, Thanks a lot for your contribution, I merged your changes on http://jpoker.aminche.com/hg/jpoker/ I believe we should add an integration test case as well in: http://jpoker.aminche.com/jpoker/jpoker/skin.html Currently jpoker_53_timeout only shows the "vertical" timeout bar (new default ?). Having jpoker_53_1_timeout_horizontal would be handy. I also added testcases to raise a few minor issues with the current and previous implementation: http://jpoker.aminche.com/jpoker/jpoker/test-jpoker.html?jpoker%20module%3A%20jpoker.plugins.table.timeout%20issues - - horizontal progress bar should use size in '%' instead of 'px', to ease skinning. - - horizontal progress bar should not override timeout element css from javascript, instead the position/size should be set in jpoker_timeout.css file for each skin. - - progress bar should use $.jpoker.plugins.table.defaults instead of $.jpoker.timerOptions for its configuration. - - horizontal and vertical progress bar should react to timeout warning and timeout notice by settings its size to 50% and 0% (or 50% and 100%). -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkkzusQACgkQZmEdV9SHoe6JEwCeN14jxwe8ARCYYbADabDtbgF3 XvUAn0u0yjcFcP2+96plHy7cfCn9+7yg =c5Zv -----END PGP SIGNATURE----- _______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
