-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Thomas Johnson wrote: > > Johan Euphrosine wrote: > >>> Thanks a lot for your contribution, I merged your changes on >>> http://jpoker.aminche.com/hg/jpoker/ >>> >>> I believe we should add an integration test case as well in: >>> http://jpoker.aminche.com/jpoker/jpoker/skin.html >>> >>> Currently jpoker_53_timeout only shows the "vertical" timeout bar (new >>> default ?). > > I am not sure if you guys want it default or not. To be honest the only > reason that I set it up that > way was to make it easier to prove that it was doing what it was supposed to > without having to edit > any code. Personally, I like the horizontal timeout(filling) better than > vertical.
I like the horizontal(emptying) better :) Without talking about the default configuration, I still think that skin.html should include one test case by timeout configuration possibility: - - horizontal filling - - horizontal emptying - - vertical filling - - vertical emptying >>> Having jpoker_53_1_timeout_horizontal would be handy. >>> >>> I also added testcases to raise a few minor issues with the current and >>> previous implementation: >>> > http://jpoker.aminche.com/jpoker/jpoker/test-jpoker.html?jpoker%20module%3A%20jpoker.plugins.table.timeout%20issues > > Thanks!.. I learned a lot from those tests. > You're welcome! >>> - horizontal progress bar should not override timeout element css from >>> javascript, instead the position/size should be set in >>> jpoker_timeout.css file for each skin. > > That had me thinking last night. We could add a class like > .jpoker_ptable_player_seat1_timeout_vertical. If that class is present in the > timeout element we > could substitute width for height in the animation. That would eliminate the > need for an extra > configuration option. Currently timeout element is generated from mockup.svg in mockup.js, but jpoker could add a css class by default when creating the table, and this css class could be passed at an options arguments to plugins.table call. Is that what you were thinking of ? >>> - progress bar should use $.jpoker.plugins.table.defaults instead of >>> $.jpoker.timerOptions for its configuration. > > That should be as simple as: > jpoker.plugins.table.defaults = $.extend({}, jpoker.defaults, > {timerFill:"fill"}); > > Correct? Or is there a better way of implementing that? > jpoker.plugins.table.defaults = $.extend(jpoker.defaults, {timerFill:"fill"}); >>> - horizontal and vertical progress bar should react to timeout warning >>> and timeout notice by settings its size to 50% and 0% (or 50% and 100%). >>> > After doing some debuging it appears that the ratio is 0 _sometimes_ when > PacketPokerTimeoutWarning > or PacketPokerTimeoutNotice are used. I say sometimes because that is not > always the case. For > instance, in the following I have changed from a height in px to %. The first > set of tests pass now > but the first two tests in the second set fail. > > Here is the code in question: > table.handler(server, game_id, { type: 'PacketPokerPosition', serial: 20, > game_id: game_id }); > equals($(".jpoker_timeout_progress", timeout_element).css("height"), "100%", > "vertical timeout > position"); > table.handler(server, game_id, { type: 'PacketPokerTimeoutWarning', serial: > 20, game_id: game_id }); > equals($(".jpoker_timeout_progress", timeout_element).css("height"), "50%", > "vertical timeout warning"); > table.handler(server, game_id, { type: 'PacketPokerTimeoutNotice', serial: > 20, game_id: game_id }); > equals($(".jpoker_timeout_progress", timeout_element).css("height"), "0%", > "vertical timeout notice"); > > Those tests pass: > vertical timeout position: 100% > vertical timeout warning: 50% > vertical timeout notice: 0% > > But the following fail: > table.handler(server, game_id, { type: 'PacketPokerPosition', serial: 20, > game_id: game_id }); > equals($(".jpoker_timeout_progress", timeout_element).css("height"), "100%", > "vertical timeout > position"); > table.handler(server, game_id, { type: 'PacketPokerTimeoutWarning', serial: > 20, game_id: game_id }); > equals($(".jpoker_timeout_progress", timeout_element).css("height"), "50%", > "vertical timeout warning"); > table.handler(server, game_id, { type: 'PacketPokerTimeoutNotice', serial: > 20, game_id: game_id }); > equals($(".jpoker_timeout_progress", timeout_element).css("height"), "0%", > "vertical timeout notice"); > > vertical timeout position expected: 100% actual: 0% > vertical timeout warning expected: 50% actual: 0% > vertical timeout notice: 0% > > It appears that ratio is 0 for all of those tests and I am not sure why. > Could you commit the latest version to http://tomfmason.net/hg/jpoker so we pull your changes and help you debugging ? Thanks in advance. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkk1VKkACgkQZmEdV9SHoe4FwgCff+mYFhitNa7gwd7tZ+JKLxIS 744AoJjKrI1XR2zIavySkA8W76gol6f4 =vnVR -----END PGP SIGNATURE----- _______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
