-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Johan Euphrosine wrote: > > Thanks a lot for your contribution, I merged your changes on > > http://jpoker.aminche.com/hg/jpoker/ > > > > I believe we should add an integration test case as well in: > > http://jpoker.aminche.com/jpoker/jpoker/skin.html > > > > Currently jpoker_53_timeout only shows the "vertical" timeout bar (new > > default ?). I am not sure if you guys want it default or not. To be honest the only reason that I set it up that way was to make it easier to prove that it was doing what it was supposed to without having to edit any code. Personally, I like the horizontal timeout(filling) better than vertical. > > > > Having jpoker_53_1_timeout_horizontal would be handy. > > > > I also added testcases to raise a few minor issues with the current and > > previous implementation: > > http://jpoker.aminche.com/jpoker/jpoker/test-jpoker.html?jpoker%20module%3A%20jpoker.plugins.table.timeout%20issues Thanks!.. I learned a lot from those tests. > > - horizontal progress bar should not override timeout element css from > > javascript, instead the position/size should be set in > > jpoker_timeout.css file for each skin. That had me thinking last night. We could add a class like .jpoker_ptable_player_seat1_timeout_vertical. If that class is present in the timeout element we could substitute width for height in the animation. That would eliminate the need for an extra configuration option. > > - progress bar should use $.jpoker.plugins.table.defaults instead of > > $.jpoker.timerOptions for its configuration. That should be as simple as: jpoker.plugins.table.defaults = $.extend({}, jpoker.defaults, {timerFill:"fill"}); Correct? Or is there a better way of implementing that? > > - horizontal and vertical progress bar should react to timeout warning > > and timeout notice by settings its size to 50% and 0% (or 50% and 100%). > > After doing some debuging it appears that the ratio is 0 _sometimes_ when PacketPokerTimeoutWarning or PacketPokerTimeoutNotice are used. I say sometimes because that is not always the case. For instance, in the following I have changed from a height in px to %. The first set of tests pass now but the first two tests in the second set fail. Here is the code in question: table.handler(server, game_id, { type: 'PacketPokerPosition', serial: 20, game_id: game_id }); equals($(".jpoker_timeout_progress", timeout_element).css("height"), "100%", "vertical timeout position"); table.handler(server, game_id, { type: 'PacketPokerTimeoutWarning', serial: 20, game_id: game_id }); equals($(".jpoker_timeout_progress", timeout_element).css("height"), "50%", "vertical timeout warning"); table.handler(server, game_id, { type: 'PacketPokerTimeoutNotice', serial: 20, game_id: game_id }); equals($(".jpoker_timeout_progress", timeout_element).css("height"), "0%", "vertical timeout notice"); Those tests pass: vertical timeout position: 100% vertical timeout warning: 50% vertical timeout notice: 0% But the following fail: table.handler(server, game_id, { type: 'PacketPokerPosition', serial: 20, game_id: game_id }); equals($(".jpoker_timeout_progress", timeout_element).css("height"), "100%", "vertical timeout position"); table.handler(server, game_id, { type: 'PacketPokerTimeoutWarning', serial: 20, game_id: game_id }); equals($(".jpoker_timeout_progress", timeout_element).css("height"), "50%", "vertical timeout warning"); table.handler(server, game_id, { type: 'PacketPokerTimeoutNotice', serial: 20, game_id: game_id }); equals($(".jpoker_timeout_progress", timeout_element).css("height"), "0%", "vertical timeout notice"); vertical timeout position expected: 100% actual: 0% vertical timeout warning expected: 50% actual: 0% vertical timeout notice: 0% It appears that ratio is 0 for all of those tests and I am not sure why. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJNqAsC+9e9bAfuVERAkYcAJ4hj5pkm/0KUyncVFByf4rUudfZrgCfUWu4 XzBobUMTkcPQpvBuO9DwBDU= =cJ4k -----END PGP SIGNATURE----- _______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
