On 24/10/14 10:05, Tomasz Torcz wrote: > On Thu, Oct 23, 2014 at 11:38:04PM +0200, Juliusz Chroboczek wrote: >> Dear Tomasz, >> >>> There was a patch posted two years ago, implementing socket activation >>> in manner compatible with systemd. The patch is here: >>> >>> https://github.com/wmanley/polipo/commit/6d0ab13bd2d421d8eb0436d8439d77c9826607cb >>> >>> Is there a chance to have it merged? >> >> You're putting me in a difficult situation. I used to be pretty >> sympathetic to the systemd effort, but the way lies and disinformation >> have been used to force it down our throats over the last years has made >> me increasingly hostile. >> >> On the other hand, you've written a small, clean, non-intrusive patch that >> introduces no new dependencies, and you've even managed to follow Polipo's >> coding conventions to the letter (with one minor exception). So I can see >> no honest reason to reject your patch, nor even a dishonest excuse. > > For clarification: I did not write the patch. William Manley did. > I find this functionality very useful, as an user. It has no impact > on non-systemd systems.
Oh, hello. Yes, I wrote it. The original thread discussing back in Feb 2012 is here[1]. The summary is: 1. I wrote some patches to add socket-passing support to polipo, not so I could use it with systemd, but because I needed to pass sockets in for other reasons. I figured I may as well re-use the systemd socket passing protocol rather than invent my own. 2. Juliusz reviewed the patches and didn't like the fact that it introduced sd_daemon.h and sd_daemon.c from systemd. 3. I rewrote the patches to not include sd_daemon.* to make the patches more amenable to Juliusz. 4. The thread petered out. I guess Juliusz was too busy with other projects at the time, and there's only so many hours in the day :). The same branch[2] added some simple automated-tests which were sufficient to find a few bugs. I think there would be real value to polipo if these were merged. [1]: http://thread.gmane.org/gmane.comp.web.polipo.user/2840 [2]: https://github.com/wmanley/polipo/commits/automated-testing2 Thanks Will ------------------------------------------------------------------------------ _______________________________________________ Polipo-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/polipo-users
