On Sun, Nov 08, 2020 at 03:31:39PM +0100, Jeremie Courreges-Anglas wrote: > On Sun, Nov 08 2020, Marc Espie <es...@nerim.net> wrote: > > On Fri, Nov 06, 2020 at 10:11:03PM -0500, Ashton Fagg wrote: > >> Hello, > >> > >> Please see attached for a new port: flatbuffers > >> (https://google.github.io/flatbuffers/). > >> > >> Quoting the homepage: > >> > >> "FlatBuffers is an efficient cross platform serialization library for > >> C++, C#, C, Go, Java, Kotlin, JavaScript, Lobster, Lua, TypeScript, PHP, > >> Python, Rust and Swift. It was originally created at Google for game > >> development and other performance-critical applications." > >> > >> The attached port builds and passes the test suite. The package installs > >> and appears to work as indended. Portcheck reports clean. There is a > >> patch included which fixes some include issues (similar to what's seen > >> in the chromium and irdium ports - which include flatbuffers as an > >> in-repo dependency). > > Is there a chance that other ports pick this flatbuffers port if > installed? chromium and iridium plus copies (qtwebengine for example). > https://codesearch.debian.net/search?q=flatbuffers might help here. > > >> There is already a similar patch in upstream's > >> queue which should land soon. > >> > >> Comments and feedback appreciated. > >> > >> Thanks, > >> > >> Ash > >> > > > > flatbuffers is among the mandatory dependencies for kodi, so > > I think this should go in (I had a similar port in my tree) > > > > any okays from other people ? > > With a bare COMPILER=ports-gcc (no explanation) and the lack of a > SHARED_LIBS* entry I think this port needs more scrutiny before import. > > Ashton: besides kodi, mentioned by Marc, do you have plans for those > flatbuffers and fmt libraries? Or do you just happen to need them for > personal work/projects?
I haven't had enough time to finish kodi, but both flatbuffers and fmt are kodi required dependencies! I will look again at my ports for flatbuffers and fmt and merge them with Ashton's port ;)
