Ashton Fagg <ash...@fagg.id.au> writes:

> Thanks for the feedback.
>
> I need them for my own purposes, but if others want to use them for
> other ports - that'd be awesome. I have another library I need which
> depends on fmt.
>
> I'll update the port with your suggestions.
>
> Thanks.

Here is an updated version with your suggestions in mind.

I've added a comment regarding why ports-gcc is required (don't know why
I didn't have that...must've forgot). It seems that the code-gen'd unit
tests don't compile with the ports-clang or base-clang. I'm not entirely
sure why and it's possibly already been fixed upstream - I'll
investigate that.

This has been tested the same way as my original submission.

I would happy to try and investigate whether this port could be used to
deduplicate stuff in other existing ports once it lands.

I'll give fmt the same treatment and send it in, back in the
corresponding thread.

Thanks!

Attachment: flatbuffers-1.12.0.tgz
Description: Binary data

Reply via email to