On Thu, Sep 15, 2022 at 10:23:00PM -0400, George Koehler wrote:
> On Thu, 15 Sep 2022 13:55:35 -0400
> Josh Grosse <j...@jggimi.net> wrote:
> 
> > A corrected tarball is attached -- pkg/DESCR was accidently empty.
> 
> I can't install p7zip with 7zip,
> 
> | Collision in p7zip-16.02p6: the following files already exist
> |         /usr/local/bin/7za (7zip-22.01 and p7zip-16.02p6)
> | Couldn't install p7zip-16.02p6
> 
> Should we declare a conflict?  See @conflict in pkg_create(8)

I've added a @conflict to the PLIST.  Thanks for catching that!
 
> Also, I need one more patch.  I attach patch-C_7zCrcOpt_c; please add
> it to your patches, so I can build 7zip on my big-endian macppc.  The
> patch prevents the errors at the end of this mail.  After I added
> patch-C_7zCrcOpt_c, I also built 7zip on powerpc64.
> 
> I might not need patch-C_7zCrcOpt_c if we would delete -Werror from the
> flags.

I've added your patch without carriage returns, and added it to
the FIX_CRLF_FILES list.

I am unsure if we should remove -Werror.  I've added several -Wno-[blah]
flags to CPP/7zip/warn_clang.mak so this would build on amd64.

Thank you for reviewing this port!

Reply via email to