On 2023/07/27 14:44, Nam Nguyen wrote: > Stuart Henderson writes: > > > tests fail to run completely here: > > > > cc -I/usr/local/include -I/usr/local/include -DHAVE_LIBSSL > > -I/usr/local/include -DNDEBUG -O2 -pipe -I/usr/local/include > > -L/usr/local/lib -o ./unit-tests ./unit-tests.c > > ./unit-tests.c:31:10: fatal error: 'wget.h' file not found > > I can reproduce this if I run `make check' in ${WRKSRC}. If I run `make > test' in the port directory it is able to run the test suite, and it > omits that compile line.
It usually fails "make test" in the port directory for me. Seems I am able to get it to work (not sure if reliably or just sometimes) with MAKE_JOBS=6 though. > > I would avoid patching tests infrastructure just to avoid test failures, > > unless those failures prevent other tests from running. > > Here is a simplified update to wget with test patching removed. > > I am waiting for feedback from upstream on two better patches that > ignore the wget-log output file in the python and perl test > scripts. This does not have to hold up the update. ok > see: > https://lists.gnu.org/archive/html/bug-wget/2023-07/msg00009.html > > OK? > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/net/wget/Makefile,v > retrieving revision 1.91 > diff -u -p -u -p -r1.91 Makefile > --- Makefile 3 Apr 2022 23:42:36 -0000 1.91 > +++ Makefile 26 Jul 2023 21:44:10 -0000 > @@ -1,6 +1,6 @@ > COMMENT = retrieve files from the web via HTTP, HTTPS and FTP > > -DISTNAME = wget-1.21.3 > +DISTNAME = wget-1.21.4 > CATEGORIES = net > > HOMEPAGE = https://www.gnu.org/software/wget/ > Index: distinfo > =================================================================== > RCS file: /cvs/ports/net/wget/distinfo,v > retrieving revision 1.28 > diff -u -p -u -p -r1.28 distinfo > --- distinfo 3 Apr 2022 23:42:36 -0000 1.28 > +++ distinfo 26 Jul 2023 21:44:10 -0000 > @@ -1,2 +1,2 @@ > -SHA256 (wget-1.21.3.tar.gz) = Vya7i8XKD23HEQ9kFuS7cBni0v9b+T0cov/MZlbyIOU= > -SIZE (wget-1.21.3.tar.gz) = 5079864 > +SHA256 (wget-1.21.4.tar.gz) = gVQvXO+4+qzDm7vGyC3tgOPkqIUFrnLqUd8nUlvN4Ew= > +SIZE (wget-1.21.4.tar.gz) = 5059591 > Index: patches/patch-Makefile_in > =================================================================== > RCS file: /cvs/ports/net/wget/patches/patch-Makefile_in,v > retrieving revision 1.6 > diff -u -p -u -p -r1.6 patch-Makefile_in > --- patches/patch-Makefile_in 3 Apr 2022 23:42:36 -0000 1.6 > +++ patches/patch-Makefile_in 26 Jul 2023 21:44:10 -0000 > @@ -1,7 +1,7 @@ > Index: Makefile.in > --- Makefile.in.orig > +++ Makefile.in > -@@ -1691,7 +1691,7 @@ distuninstallcheck_listfiles = find . -type f | \ > +@@ -1895,7 +1895,7 @@ distuninstallcheck_listfiles = find . -type f | \ > ACLOCAL_AMFLAGS = -I m4 > > # subdirectories in the distribution > Index: pkg/PLIST > =================================================================== > RCS file: /cvs/ports/net/wget/pkg/PLIST,v > retrieving revision 1.29 > diff -u -p -u -p -r1.29 PLIST > --- pkg/PLIST 11 Mar 2022 19:48:11 -0000 1.29 > +++ pkg/PLIST 26 Jul 2023 21:44:10 -0000 > @@ -50,6 +50,10 @@ share/locale/it/LC_MESSAGES/wget-gnulib. > share/locale/it/LC_MESSAGES/wget.mo > share/locale/ja/LC_MESSAGES/wget-gnulib.mo > share/locale/ja/LC_MESSAGES/wget.mo > +share/locale/ka/ > +share/locale/ka/LC_MESSAGES/ > +share/locale/ka/LC_MESSAGES/wget-gnulib.mo > +share/locale/ka/LC_MESSAGES/wget.mo > share/locale/ko/LC_MESSAGES/wget-gnulib.mo > share/locale/ko/LC_MESSAGES/wget.mo > share/locale/lt/