On Thu, 17 Aug 2023 07:10 +0200, Theo Buehler wrote:
> On Wed, Aug 16, 2023 at 11:01:38PM -0600, Ashlen wrote:
> > Selene is a modern Lua linter written in Rust.
> > 
> > GitHub: https://github.com/Kampfkarren/selene
> > Docs: https://kampfkarren.github.io/selene/
> > 
> > This was easy enough to port. Tests run and pass. do-install hook
> > seems to be needed due to a `Cargo.toml` issue.
> 
> Try setting
> 
> MODCARGO_INSTALL_TARGET_PATH = selene
> 
> instead.
> 

Thanks, I see your commit to devel/cargo/cargo.port.mk on 2023/07/24.

While there, I also changed WANTLIB to use MODCARGO_WANTLIB, and
adjusted tabs for alignment.

Side note: I noticed MODCARGO_INSTALL_TARGET_PATH is undocumented
in cargo-module(5), along with MODCARGO_WANTLIB. Should they be
included in that man page?
--- Makefile.orig       Thu Aug 17 00:01:43 2023
+++ Makefile    Thu Aug 17 00:01:54 2023
@@ -1,31 +1,28 @@
-COMMENT =              modern Lua linter written in Rust
+COMMENT =                      modern Lua linter written in Rust
 
-V =                    0.25.0
-DISTNAME =             selene-${V}
+V =                            0.25.0
+DISTNAME =                     selene-${V}
 
-GH_ACCOUNT =           Kampfkarren
-GH_PROJECT =           selene
-GH_TAGNAME =           ${V}
+GH_ACCOUNT =                   Kampfkarren
+GH_PROJECT =                   selene
+GH_TAGNAME =                   ${V}
 
-CATEGORIES =           devel
+CATEGORIES =                   devel
 
-HOMEPAGE =             https://kampfkarren.github.io/selene/
+HOMEPAGE =                     https://kampfkarren.github.io/selene/
 
-WANTLIB +=             c c++abi pthread
+WANTLIB +=                     ${MODCARGO_WANTLIB}
 
 # Mozilla Public License 2.0
-PERMIT_PACKAGE =       Yes
+PERMIT_PACKAGE =               Yes
 
-MODULES =              devel/cargo
-CONFIGURE_STYLE =      cargo
-SEPARATE_BUILD =       Yes
+MODULES =                      devel/cargo
+CONFIGURE_STYLE =              cargo
+SEPARATE_BUILD =               Yes
 
-BUILD_DEPENDS =                security/rust-ring
+BUILD_DEPENDS =                        security/rust-ring
 
-RELEASE_DIR =          ${MODCARGO_TARGET_DIR}/release
-
-do-install:
-       ${INSTALL_PROGRAM} ${RELEASE_DIR}/selene ${PREFIX}/bin/
+MODCARGO_INSTALL_TARGET_PATH = selene
 
 .include "crates.inc"
 

Reply via email to