On Wed, Sep 12, 2007 at 04:17:53PM -0700, Roland Philippsen wrote: > Simon Bertrang wrote: > > On Mon, Sep 10, 2007 at 11:59:27PM -0400, Mike Erdely wrote: > >> On Sun, Sep 09, 2007 at 12:57:30PM -0700, Roland Philippsen wrote: > >>> here's a suggestion for adding an Apache2-flavor to www/mod_fastcgi. > >>> The patch (created with git) is best applied using 'patch -p2' from > >>> within the mod_fastcgi directory. > ... > >> I made a couple tweaks and used "cvs diff" (below). > ... > > Another proposal using MULTI_PACKAGES instead of FLAVOR which allows to > > install both at the same time. > > patches/patch-fcgi_h works in both version, so i changed it to apply > > unconditionally which make the Makefile even smaller. > > Thanks for the input. I didn't test your patch yet, but... > > The reason why I hadn't opted for MULTI_PACKAGES was that it would > change the default behavior of the port. People who "want just the > good old thing" would be forced to specify SUBPACKAGE=main in the > environment when building mod_fastcgi, otherwise they're forced to > install apache-httpd, which might not be exactly what they want. > > Or am I missing something here? >
No, i actually thought about it and probably a pseudo flavor like ap2 could enable the additional package. If you like to you can sprinkle the required .if's other the few places where it matters. I think the maintainer will also have an opinion to that and he's on the cc list now... mbalmer enlighten us :-) Regards, Simon
